Add create and update timestamps to Resource objects#70
Merged
apex-omontgomery merged 6 commits intoOperationCode:masterfrom Dec 24, 2018
Merged
Add create and update timestamps to Resource objects#70apex-omontgomery merged 6 commits intoOperationCode:masterfrom
apex-omontgomery merged 6 commits intoOperationCode:masterfrom
Conversation
Member
Author
|
Query should look like this The model itself should have something like this That way, any changes made on the database (outside the app) will also have timestamps. See here |
be1d64e to
a91d125
Compare
0702622 to
d440fc9
Compare
169a1ea to
d8ef4f6
Compare
Member
Author
|
@wimo7083 I need help writing tests for this. Can you hit me up on slack when you get a chance? |
ac7714b to
b6dd327
Compare
apex-omontgomery
approved these changes
Dec 24, 2018
Member
apex-omontgomery
left a comment
There was a problem hiding this comment.
Very nice, looking great.
This was referenced Dec 24, 2018
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #66.
I am thinking we'll probably need to add a parameter to the
GET /resourcesroute so that the front end can actually query for resources based on thecreated_atorlast_updateddata. Let me know if you want to see that as part of this PR.I'm willing to have a discussion about whether we should include these timestamps in the data returned by all requests (I wasn't sure so I decided to not include it until we can have a discussion about it).